Re: [PATCH] NFSd: nfs4_preprocess_seqid_op should only set *stpp on success

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 7 Jun 2014 07:08:00 -0700
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:

> On Fri, Jun 06, 2014 at 02:56:34PM -0400, Jeff Layton wrote:
> > From: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
> > 
> > Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>
> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
> 
> The new code looks correct, but shouldn't callers already take care
> not to use the returned stateid only if nfs4_preprocess_seqid_op returns
> 0?
> 

Yeah, I mentioned that to Bruce on IRC. This is not really a bugfix,
per-se, but more of a defensive coding measure.

-- 
Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux