On Sun, May 11, 2014 at 10:41:15PM -0700, Christoph Hellwig wrote: > > +struct nfsd4_operation *OPDESC(struct nfsd4_op *op) > > I don't think OPDESC is a good name for a non-static function. > > > But looking at the whoile tree we only need the exposed information > in two simple places in nfs4xdr.c, so I'd suggest to export something > higher level instead, e.g. move nfsd4_max_reply into nfs4proc.c > and have a helper to check that the op doesn't modify anything and > warn if it does. > Sure, makes sense; done. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
