On Tue, May 20, 2014 at 02:08:07PM -0400, Anna Schumaker wrote: > There is a lot of duplicate code in pnfs.c that can be cleaned up to > share more code. This patch set goes through each function one at a > time and merges read and write code together wherever possible. In the > end I'm passing around a few function pointers. Would it be better to > use a function pointer struct instead? No chance to share this with the r/w ops for the classic code? Aso I think it would be even better if a lot of this code could be mergedinto the classic code path, it seems like we'd mostly need pnfs_get/put_lseg in common code for this. pnfs_get_lseg is so trivial that it's not a problem, and the put could be done by simply giving each lseg a free function pointer. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
