Re: [PATCH 8/8] pnfs: merge identical functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 19, 2014 at 12:11:30PM -0400, Anna Schumaker wrote:
> > I think it should also be mossible to simply call pnfs_put_lseg
> > from nfs_pgio_header_free.  pnfs_put_lseg handles a NULL argument fine,
> > is stubbed out for the non-pnfs case, and the other callers should never
> > have it set.
> 
> Every function in this area is identical to each other :).  I'm already working on a patch series that combines these functions (and more!).  It also needs more testing before I can submit, but I can update against these patches first to see if this unlocks other cleanups.

Yes, pnfs.c has lots of duplication of the classic I/O path.  I don't
think we need to rush out your patches, but it would be good to get them
out in the not too far future.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux