On Mon, May 12, 2014 at 01:18:01AM -0700, Christoph Hellwig wrote: > On Sun, May 11, 2014 at 04:52:11PM -0400, J. Bruce Fields wrote: ... > > - op->status = nfsd4_enc_ops[op->opnum](resp, op->status, &op->u); > > + encoder = nfsd4_enc_ops[op->opnum]; > > + op->status = encoder(resp, op->status, &op->u); > > What is the point of the encoder variable that gets set and used a line > later the only time? I find the two new lines above a little easier to read than the single original line. That's all. But I don't feel strongly about it. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
