Re: [PATCH 02/43] nfsd4: tweak nfsd4_encode_getattr to take xdr_stream

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>   * Note: @fhp can be NULL; in this case, we might have to compose the filehandle
>   * ourselves.
> - *
> - * countp is the buffer size in _words_
>   */
>  __be32
> -nfsd4_encode_fattr(struct svc_fh *fhp, struct svc_export *exp,
> -		struct dentry *dentry, __be32 **buffer, int count, u32 *bmval,
> +nfsd4_encode_fattr(struct xdr_stream *xdr, struct svc_fh *fhp, struct svc_export *exp,

Can you make sure that line that the patches touch don't exceed 80
lines?  There's quite a few more through the series, including new code.


Otherwise looks good,

Signed-off-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux