On Fri, May 09, 2014 at 05:40:57PM -0400, J. Bruce Fields wrote: > On Fri, May 09, 2014 at 03:55:03PM +0800, Kinglong Mee wrote: > > On 5/9/2014 00:12, J. Bruce Fields wrote: > > > I'd like to apply this if only to remove the redundant code. > > > > > > I'd like to understand, though, whether this is something that caused an > > > actual practical problem for someone, or if you just happened to notice > > > the inconsistency between nfs and ext4 behavior? > > > > I test it with ext2,ext3,btrfs,xfs. > > Test result is same as ext4. > > So, we needs remove the redundant killing of suid/sgid. > > Understood that this would make the behavior consistent with > filesystems. But, you don't know of any cases of the current behavior > is actually causing a problem for anyone? I thin this also is the root cause for xfstests generic/193 failing on NFS, but I haven't verified it yet. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
