On Thu, May 08, 2014 at 03:40:49PM -0400, Trond Myklebust wrote: > On Wed, May 7, 2014 at 3:25 PM, Bruce Fields <bfields@xxxxxxxxxxxx> wrote: > > We're adding a put without adding a corresponding get, so was there a > > leak before this patch? > > No. The struct sc_file is added by this patch, and since the entire > stid is zeroed on allocation (through the use of kmem_cache_zalloc), > it is safe to add the put() in this patch. It's safe, but it would still be nicer to have a single patch that just moves the file from the delegation to the generic stateid. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
