Re: [PATCH] nfsd: clean up fh_auth usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 08, 2014 at 08:27:23AM +0200, Christoph Hellwig wrote:
> On Wed, May 07, 2014 at 12:01:18PM -0400, J. Bruce Fields wrote:
> > On Wed, May 07, 2014 at 01:49:44PM +0200, Christoph Hellwig wrote:
> > > Use fh_fsid when reffering to the fsid part of the filehandle.  The
> > > variable length auth field envisioned in nfsfh wasn't ever implemented.
> > > Also clean up some lose ends around this and document the file handle
> > > format better.
> > 
> > Thanks.
> > 
> > > Btw, why do we even export nfsfh.h to userspace?  The file handle very
> > > much is kernel private, and nothing in nfs-utils include the header
> > > either.
> > 
> > Something like wireshark might use that information?  But anyway that
> > doesn't mean it makes much sense to export.  I'm fine with moving that
> > header.
> 
> Let's just put this version in for now,

OK, doing that.

> I'll do some research if the uapi <linux/nfsd/*.h> headers are used
> anywhere at all, if not I'll send a series to kill them all.

Thanks!

--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux