On Tue, May 06, 2014 at 11:32:00AM -0400, Bruce Fields wrote: > On Fri, Apr 18, 2014 at 02:43:55PM -0400, Trond Myklebust wrote: > > Otherwise, we may end up triggering all those nfsd4_has_session() > > tests. > > Surely we'd have seen failures if this was actually not zeroed.... > > Right, I think the > > memset(rqstp->rq_argp, 0, procp->pc_argsize); > > in svc_process_common() handles this. > > But apparently the lack of an explicit assignment was confusing. So > maybe it's better to have one. > > (Or if not, to get rid of the other unnecessary assignments.) (Dropping, assuming you'll resend with updated changelog if you feel strongly about it....). > > --b. > > > > > Signed-off-by: Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx> > > --- > > fs/nfsd/nfs4proc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c > > index d543222babf3..8eabbfb25441 100644 > > --- a/fs/nfsd/nfs4proc.c > > +++ b/fs/nfsd/nfs4proc.c > > @@ -1293,6 +1293,7 @@ nfsd4_proc_compound(struct svc_rqst *rqstp, > > cstate->minorversion = args->minorversion; > > cstate->replay_owner = NULL; > > cstate->session = NULL; > > + cstate->slot = NULL; > > fh_init(current_fh, NFS4_FHSIZE); > > fh_init(save_fh, NFS4_FHSIZE); > > /* > > -- > > 1.9.0 > > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
