ping? This is a fairly serious data integrity issue for pnfs users. On Mon, Apr 21, 2014 at 10:29:17AM -0700, Christoph Hellwig wrote: > >From fdatasync(2): > > "fdatasync() is similar to fsync(), but does not flush modified metadata > unless that metadata is needed in order to allow a subsequent data > retrieval to be correctly handled." > > We absolutely need to commit the layouts to be able to retrieve the data > in case either the client, the server or the storage subsystem go down. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > diff --git a/fs/nfs/nfs4file.c b/fs/nfs/nfs4file.c > index 8de3407..464db9d 100644 > --- a/fs/nfs/nfs4file.c > +++ b/fs/nfs/nfs4file.c > @@ -100,8 +100,7 @@ nfs4_file_fsync(struct file *file, loff_t start, loff_t end, int datasync) > break; > mutex_lock(&inode->i_mutex); > ret = nfs_file_fsync_commit(file, start, end, datasync); > - if (!ret && !datasync) > - /* application has asked for meta-data sync */ > + if (!ret) > ret = pnfs_layoutcommit_inode(inode, true); > mutex_unlock(&inode->i_mutex); > /* > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html ---end quoted text--- -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
