> cr_linkname maybe a path contains '/', or '.', > check_filename will return error nfserr_badname for those path. > > IMO, just check whether the length is zero as, > > if (create->cr_linklen == 0) > return nfserr_inval; > Hmm, right, checking for a '/' not right here. Checking if link-name is "." or ".." isn't required, but shouldn't hurt either. But on the other hand we can leave that to the underlying file system. Thanks for your review! Bernd -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html