On 2014/4/18 20:13, J. Bruce Fields wrote:
On Thu, Apr 17, 2014 at 07:36:34AM -0700, Christoph Hellwig wrote:
On Thu, Apr 17, 2014 at 08:46:11PM +0800, Kinglong Mee wrote:
After setting ACL for directory, I got two problems that caused
by the cached zero-length default posix acl.
This patch just clears the cached zero-length default posix acl
after setting.
First problem:
# nfs4_setfacl -s A::OWNER@:RWX /mnt/123/; touch /mnt/123/test
............ hang ...........
Nfsd must not call forget_cached_acl, that's the filesystems job.
I think the right fix is to make sure nfsd4_set_nfs4_acl calls ->set_acl
with a NULL ACL structure if there are no entries.
Btw, it would be really good if we kept tests like this as a regression
test suite. Is there one for NFS already? If not we could add
nfs-specific tests to xfstests as well.
I'd recommend pynfs for something like this.
(It talks NFSv4 directly to the server, so won't depend on client
acl-caching behavior, etc.)
Make sense.
I will try to add some test cases for ACL to pynfs.
Thanks,
Kinglong Mee
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
