On Tue, Mar 25, 2014 at 08:36:32AM -0700, Christoph Hellwig wrote: > On Sun, Mar 23, 2014 at 11:07:22AM -0400, J. Bruce Fields wrote: > > In the splice case read increments page_len as it goes. This leaves the > > xdr_buf in somewhat of an inconsistent state and may confuse a later > > xdr_truncate_encode. > > > > It's a little ugly, I'm not sure what to do about it. Currently I'm > > thinking of just telling nfsd's splice callback to leave page_len alone. > > That'd mean taking another look at the splice callback and at the v2/v3 > > read code. > > How a about just adding a comment explaing this for now? OK, done.--b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
