On Sat, Mar 29, 2014 at 06:41:54AM +0800, Kinglong Mee wrote: > > > 于 2014/3/29 05:19, J. Bruce Fields 写道: > >On Wed, Mar 26, 2014 at 05:12:09PM +0800, Kinglong Mee wrote: > >>Testing NFS4.0 by pynfs, I got some messeages as, > >>"nfsd: inode locked twice during operation." > > > >Thanks for looking into this. I agree that we should clear fh_pre_saved > >and fh_post_saved between compound ops. > > > >This is kind of non-obvious, though, so I think it would be worth moving > >these two assignments to a little helper function (how about > >"fh_clear_wcc_data()" for a name?) and adding a comment with the > >definition of the function, explaining why we need it. > > That's great. > Thanks for your advice. > > > > >>When one compound RPC contains two or more SETATTR operation > >>for one filehandle,the second SETATTR will cause the message. > > > >Also worth noting that this affects any op that locks the filehandle > >(e.g. a compound with two LINK ops would probably trigger the same > >warning.) > > Yes, that's right. OK, thanks, I'll assume you're sending a revised patch. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
