On Wed, Mar 19, 2014 at 09:11:35AM -0400, Anna Schumaker wrote: > On 03/19/2014 03:41 AM, Christoph Hellwig wrote: > > On Tue, Mar 18, 2014 at 02:04:28PM -0400, Anna Schumaker wrote: > >>> The other option would be to simply always have the pnfs_curr_ld field > >>> in the server structure and remove the ifdef entirely. > >> Okay. If we keep the ifdef, then it should probably check for CONFIG_NFS_V4_1 and not CONFIG_NFS_V4 > > The field in the header is under CONFIG_NFS_V4, so I tried to make it > > consistent. > > > struct pnfs_layoutdriver_type comes from fs/nfs/pnfs.h under a CONFIG_NFS_V4_1 check, so you can't access pg_write_ops or pg_read_ops without v4.1 enabled. You're right - the field exists for plain v4, but we can't dereference it unless 4.1 support is enable. I'll send an update. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
