Re: [PATCH 2/8] NFS: prepare for RCU-walk support but pushing tests later in code.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 05, 2014 at 02:00:28PM +1100, NeilBrown wrote:
> -	parent = dget_parent(dentry);
> +		parent = rcu_dereference(dentry->d_parent);
> +	else
> +		parent = dget_parent(dentry);
>  	dir = parent->d_inode;
>  	nfs_inc_stats(dir, NFSIOS_DENTRYREVALIDATE);

... and in RCU mode there's nothing to stop parent from
	a) not being dentry->d_parent anymore
	b) having already become negative.

NAK.
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux