On Mar 1, 2014, at 11:00 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote: > On Fri, 28 Feb 2014 21:59:00 -0500 > Chuck Lever <chuck.lever@xxxxxxxxxx> wrote: > >> Hi Wendy- >> >> On Feb 28, 2014, at 5:26 PM, Wendy Cheng <s.wendy.cheng@xxxxxxxxx> wrote: >> >>> On Fri, Feb 28, 2014 at 2:20 PM, Wendy Cheng <s.wendy.cheng@xxxxxxxxx> wrote: >>>> ni i...On Fri, Feb 28, 2014 at 1:41 PM, Tom Talpey <tom@xxxxxxxxxx> wrote: >>>>> >>>>> On 2/26/2014 8:44 AM, Chuck Lever wrote: >>>>>> >>>>>> Hi- >>>>>> >>>>>> Shirley Ma and I are reviving work on the NFS/RDMA client code base in >>>>>> the Linux kernel. So far we've built and run functional tests to determine >>>>>> what is working and what is broken. >>>>>> >>>>>> [snip] >>>> >>>> >>>>>> >>>>>> ALLPHYSICAL - Usually fast, but not safe as it exposes client memory. >>>>>> All HCAs support this mode. >>>>> >>>>> >>>>> Not safe is an understatement. It exposes all of client physical >>>>> memory to the peer, for both read and write. A simple pointer error >>>>> on the server will silently corrupt the client. This mode was >>>>> intended only for testing, and in experimental deployments. >>> >>> (sorry, resend .. previous reply bounced back due to gmail html format) >>> >>> Please keep "ALLPHYSICAL" for now - as our embedded system needs it. >> >> This is just the client side. Confirming that you still need support for the ALLPHYSICAL memory registration mode in the NFS/RDMA client. >> >> Do you have plans to move to a mode that is less risky? If not, can we depend on you to perform regular testing with ALLPHYSICAL as we update the client code? Do you have any bug fixes you’d like to merge upstream? >> > > Also, given that ALLPHYSICAL isn't considered safe, we should at the > very least require some sort of explicit opt-in before allowing it to be > used. Perhaps either a Kconfig option, or maybe a runtime switch like a > module parm? Well, there is already an opt-in: /proc/sys/sunrpc/rdma_memreg_strategy selects the default registration mode. Currently FRMR is always used unless the HCA doesn’t support it. If we need to keep ALLPHYSICAL, the least thing I would want to do is remove the logic in rpcrdma_ia_open() that switches to ALLPHYSICAL if the mode selected by rdma_memreg_strategy isn’t supported by the HCA. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
