On Tue, 18 Feb 2014 03:48:48 -0500 Steve Dickson <steved@xxxxxxxxxx> wrote: > The file /proc/net/rpc/use-gss-proxy exists whether > gss-proxy is or is not installed. So is existence > can not be used as start up trigger. > > Signed-off-by: Steve Dickson <steved@xxxxxxxxxx> > --- > systemd/rpc-svcgssd.service | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/systemd/rpc-svcgssd.service b/systemd/rpc-svcgssd.service > index 6bd4588..8e10b98 100644 > --- a/systemd/rpc-svcgssd.service > +++ b/systemd/rpc-svcgssd.service > @@ -7,7 +7,6 @@ PartOf=nfs-utils.service > > After=gssproxy.service > ConditionPathExists=|!@localstatedir@/run/gssproxy.pid > -ConditionPathExists=|!/proc/net/rpc/use-gss-proxy > ConditionPathExists=/etc/krb5.keytab > > [Service] This is testing for non-existence, not existence. We need rpc-svcgssd unless gssproxy can perform that task for us, in which case we don't want rpc-svcgssd. gssproxy can only perform the task for us if: 1/ it is running (hence the test on the pid file) 2/ the kernel knows how to talk to it (hence the test on use-gss-proxy) With you version, if gssproxy were running on a kernel which did not include support for nfsd talking to gssproxy, then rpc-svcgssd would fail to start, which isn't what we want. This may be an unusual configuration but unless it is an impossible configuration I would rather the code remained as it was. (This should work on *all* distros, not just sane distros). Thanks, NeilBrown
Attachment:
signature.asc
Description: PGP signature
