On Feb 11, 2014, at 21:12, shaobingqing <shaobingqing@xxxxxxxxxxxxx> wrote: > 2014-02-12 3:43 GMT+08:00 Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>: >> The call to xprt_free_allocation() will call list_del() on >> req->rq_bc_pa_list, which is not attached to a list. > > Since the type of req->rq_bc_pa_list is struct list_head, I think it > is right on the tmp_list or > the xprt->bc_pa_list. Do I misunderstand sth? Not when xprt_free_bc_request() calls xprt_free_allocation(). >> This patch moves the list_del() out of xprt_free_allocation() >> and into those callers that need it. …and the point is that we do not add the list_del() to xprt_free_bc_request(). _________________________________ Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html