On Feb 3, 2014, at 3:03, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > On Fri, Jan 31, 2014 at 03:59:30PM -0500, Trond Myklebust wrote: >> posix_acl_xattr_get requires get_acl() to return EOPNOTSUPP if the >> filesystem cannot support acls. This is needed for NFS, which can't >> know whether or not the server supports acls until it tries to get/set >> one. >> This patch converts posix_acl_chmod and posix_acl_create to deal with >> EOPNOTSUPP return values from get_acl(). > > Shouldn't NFS just return a NULL ACL here? As I said above, that causes posix_acl_xattr_get() to return the wrong answer (ENODATA instead of EOPNOTSUPP). -- Trond Myklebust Linux NFS client maintainer -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html