Currently, the write_gssp code will change the variable and wake up any waiters waiting on that change. It then goes and tries to set the gssp_clnt. This is racy -- a task waiting on the set_gss_proxy call may end up waking up and then subsequently finding that the gss_clnt isn't there yet and end up not using it even though it'll soon be ready. This patch reverses the order of operations. The gssp_clnt is created first, and the variable change is done only if that succeeds. Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx> --- net/sunrpc/auth_gss/svcauth_gss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c index 921f388..17c24bd 100644 --- a/net/sunrpc/auth_gss/svcauth_gss.c +++ b/net/sunrpc/auth_gss/svcauth_gss.c @@ -1344,10 +1344,10 @@ static ssize_t write_gssp(struct file *file, const char __user *buf, return res; if (i != 1) return -EINVAL; - res = set_gss_proxy(net, 1); + res = set_gssp_clnt(net); if (res) return res; - res = set_gssp_clnt(net); + res = set_gss_proxy(net, 1); if (res) return res; return count; -- 1.8.4.2 -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
