On Mon, Dec 16, 2013 at 07:16:00PM +0100, Joakim Tjernlund wrote: > rpc.nfsd insists on adding "-4.2" when writing /proc/fs/nfsd/versions : > rpc.nfsd: Writing version string to kernel: +4.1 -4.2 -2 +3 +4 > Which causes Linux to return an EIVAL error as 3.10 has no support for 4.2 > and > does not accept any reference to 4.2 > > It seems reasonable to me that Linux should accpect -4.2 as a noop and > continue > processing the rest of the options but I am just guessing. > Anyhow, just to test I applied this commit to my 3.10.24 kernel: > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=4bdc33ed5bd9fbaa243bda6fdccb22674aed6305 > and now it accepts the "-4.2" but I have no idea if this messes up > something else. That should be perfectly safe. I agree that we should teach the kernel to treat "-4.x" at least as a no-op for unknown .x. But nfs-utils also has to keep working with older kernels which don't do that. The problem was introduced by 12a590f8d556c00a9502eeebaa763d906222d521 "rpc.nfsd: Allow v4.2 server support with the -V option". That should be using an array of ints not a bit array, so it can make the distinction between "off", "on", and "don't care". --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
