On Mon, Dec 09, 2013 at 07:05:43PM +0200, Benny Halevy wrote:
> Signed-off-by: Benny Halevy <bhalevy@xxxxxxxxxxxxxxx>
Are you sure? Reminding myself from the sprintf man page.... %*s
provides padding, %.*s limits the number of characters taken from the
string. We need that limit since there's no guarantee of null
termination here.
--b.
> ---
> fs/nfsd/nfs4proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index 0a964f1..8624bee 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -361,7 +361,7 @@ nfsd4_open(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
> struct net *net = SVC_NET(rqstp);
> struct nfsd_net *nn = net_generic(net, nfsd_net_id);
>
> - dprintk("NFSD: nfsd4_open filename %.*s op_openowner %p\n",
> + dprintk("NFSD: nfsd4_open filename %*s op_openowner %p\n",
> (int)open->op_fname.len, open->op_fname.data,
> open->op_openowner);
>
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
