On Nov 18, 2013, at 13:41, Anna Schumaker <bjschuma@xxxxxxxxxx> wrote: > On 11/18/2013 01:37 PM, Myklebust, Trond wrote: >> >> On Nov 18, 2013, at 12:50, Anna Schumaker <bjschuma@xxxxxxxxxx> wrote: >>> >>> It's a poorly phrased commit message, actually. I meant that just setting CONFIG_NFS_USE_LEGACY_DNS=y causes build problems, and then setting CONFIG_NFS_V4=n causes a different set of errors. >> >> Ah. OK, now I see why you need it. The code in fs/nfs/super.c relies on it when !defined CONFIG_NFS_V4. >> >> You also need to move the CONFIG_NFS_V4_SECURITY_LABEL section outside the CONFIG_NFS_V4, since fs/nfs/dir.c and others need the dummy nfs4_label_alloc and nfs4_label_free inline functions (see Stephen Rothwell >> ’s email). > > Right. I have a patch that moves them to internal.h instead to get around the whole-file #ifdef that's in nfs4_fs.h. Would you prefer me to submit that independently or as a v2 to this patch? Please do it as a v2. > As a bonus, I've used Jenkins to compile as many combinations as possible without an error (I probably should have done that the first time, though...) -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
