On Mon, Nov 18, 2013 at 06:16:24AM -0800, Christoph Hellwig wrote: > On Mon, Nov 18, 2013 at 09:10:31AM -0500, J. Bruce Fields wrote: > > On Mon, Nov 18, 2013 at 05:07:30AM -0800, Christoph Hellwig wrote: > > > Split out two helpers to make the code more readable and easier to verify > > > for correctness. > > > > Thanks, both queued up for 2.14. > > The write counter leak on a break_lease failure is quite serious, > given that nfsd_break_lease passes O_NONBLOCK and thus remote users > can arbitrarily trigger it. Oops, I read too quickly and thought it was just cleanup. Looks like I introduced that bug into 2.6.38 with 6a76bebefe15d9a08864f824d7f8d5beaf37c997 "nfsd4: break lease on nfsd setattr" OK, added a sentence saying that to the second path and I'll pass it along with stable cc:'s after some testing. --b. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
