Re: [PATCH] NFS: -EIO from decode_bitmap if too many bitmaps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2013-11-15 at 12:00 -0500, Trond Myklebust wrote:
+AD4- On Fri, 2013-11-15 at 11:38 -0500, Weston Andros Adamson wrote:
+AD4- +AD4- decode+AF8-bitmap will only decode up to three bitmaps.  If the xdr buffer
+AD4- +AD4- has more than three bitmaps, return -EIO here instead of bailing out in
+AD4- +AD4- a later xdr decode.
+AD4- +AD4- 
+AD4- 
+AD4- No. decode+AF8-bitmap will only +AF8-save+AF8- 3 words in the bitmap+AFsAXQ- argment, but
+AD4- it will decode arbitrary sized bitmaps:
+AD4- 
+AD4- 	p +AD0- xdr+AF8-inline+AF8-decode(xdr, (bmlen +ADwAPA- 2))+ADs-
+AD4- 

That said, we should probably check that the server isn't setting those
bitmap words to any non-zero values. That would be a reason to return
EIO.


-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust+AEA-netapp.com
www.netapp.com
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux