On Fri, 15 Nov 2013 06:28:47 -0800
Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Thu, Nov 14, 2013 at 01:35:51PM -0500, Jeff Layton wrote:
> > Hrm... I started chasing down a bug reported by our QA group last week
> > that's showing up when you mix DIO writes and buffered reads
> > (basically, diotest3 in the LTP suite is failing). The bug is marked
> > private for dumb reasons but I'll see if I can make it public. I'll
> > also plan to give this series a spin to see if it helps fix that bug...
> >
> > In any case, the DIO write code calls nfs_zap_mapping after it gets the
> > WRITE reply. That sets NFS_INO_INVALID_DATA and should prevent buffered
> > read() calls from getting data out of the cache after the write reply
> > comes in.
> >
> > Why is that not sufficient here?
>
> Sounds like it should actually be fine, although I had similar testcases
> fail. I didn't even notice we were doing the invalidation, but delaying
> it. Can't see how that helps when bringing mmap into the game, although
> that was always an best effort and pray that it works scenario.
>
Ok, cool. The bug that I've been looking at with Trond's help is here:
https://bugzilla.redhat.com/show_bug.cgi?id=919382
Do you have these patches in a git tree someplace? If so, I wouldn't
mind running this reproducer against it to see if it helps. It's a bit
of a longshot, but what the heck...
--
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
