On Tue, 2013-11-12 at 11:57 -0500, J. Bruce Fields wrote: +AD4- On Tue, Nov 12, 2013 at 11:20:21AM -0500, Jeff Layton wrote: +AD4- +AD4- On Tue, 12 Nov 2013 10:55:39 -0500 +AD4- +AD4- Jeff Layton +ADw-jlayton+AEA-redhat.com+AD4- wrote: +AD4- +AD4- +AD4- +AD4- +AD4- On Tue, 12 Nov 2013 15:31:34 +-0000 +AD4- +AD4- +AD4- Weston Andros Adamson +ADw-dros+AEA-netapp.com+AD4- wrote: +AD4- +AD4- +AD4- +AD4- How that ends up smashing the stack, I'm not sure though. +AD4- +AD4- rpc+AF8-free+AF8-client(clnt) +AD4- rpc+AF8-release+AF8-client(clnt-+AD4-cl+AF8-parent) +AD4- rpc+AF8-free+AF8-auth(clnt) +AD4- free+AF8-free+AF8-client(clnt) +AD4- +AD4- So freeing a client with N ancestors can take N times the stack as +AD4- freeing a single client. +AD4- +AD4- (Are there any other cases that can create arbitrarily long cl+AF8-parent +AD4- chains?) Ewww.... At this point, that would be pretty much anything that calls rpc+AF8-clone+AF8-client+AF8-set+AF8-auth() in response to a NFS4ERR+AF8-WRONG+AF8-SEC. -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust+AEA-netapp.com www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html