On 28/10/13 18:35, NeilBrown wrote: > On Tue, 22 Oct 2013 04:36:24 -0400 Steve Dickson <SteveD@xxxxxxxxxx> wrote: > >> >> >> On 22/10/13 04:30, Steve Dickson wrote: >>> >>> >>> On 02/10/13 19:29, Tony Asleson wrote: >>>> To improve error handling when scripting exportfs it's useful >>>> to have non-zero exit codes when the requested operation did not >>>> succeed. >>>> >>>> This patch also returns a non-zero exit code if you request to >>>> unexport a non-existant share. >>>> >>>> Signed-off-by: Tony Asleson <tasleson@xxxxxxxxxx> >>> Committed! >> Unfortunately I did not see Neil's patch before I committed this patch.... >> So I'm going to revert this patch in favor of Neil's... >> >> steved. > > Hi Steve, > > it doesn't look like you achieved the result you were after. > > commit 956aeff2e24304e938846f81f4b9db34cbf18a32 > is Tony's original patch. > commit efe3c8d6cb4fc35909a64c0535087676a189fa5f > reverts it. > > commit 232eb7ad09f9fd2ae4918699f850e4f8cadc2632 > apples Tony's original patch again, but is credited > to me with my patch description. > > So something is a bit messed up. > That is why my subsequent > exportfs: report failure if asked to unexport something not exported. > > didn't apply. Yea... I had a tough week last week... Let me sort this out and do the right thing... steved. > > NeilBrown > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
