> +__be32 nfsd4_vfs_fallocate(struct file *file, bool allocated, loff_t offset, loff_t len)
> +{
> + int error, mode = 0;
> +
> + if (allocated == false)
> + mode = FALLOC_FL_PUNCH_HOLE | FALLOC_FL_KEEP_SIZE;
> +
> + error = do_fallocate(file, mode, offset, len);
> + if (error == 0)
> + error = vfs_fsync_range(file, offset, offset + len, 0);
What are you trying to do with the fsync_range here? If it's just to
make sure the metadata operation is stable on disk please use commit_metadata()
from fs/nfsd/vfs.c. As there's no data involved here I can't really see
what else it would be for.
Also the allocated flag doesn't make any sense for people not taking the
same drugs as the spec authors, please add a comment what it means.
Btw, how did anyone come up with the name WRITE PLUS for something that
doesn't actually involve any writes?
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
