On Mon, 2013-10-21 at 09:52 -0400, Jeff Layton wrote: +AD4- Currently the kernel returns -EINVAL, which makes it hard to +AD4- distinguish this situation from the case where an invalid mount option +AD4- was specified. +AD4- +AD4- Signed-off-by: Jeff Layton +ADw-jlayton+AEA-redhat.com+AD4- +AD4- --- +AD4- fs/nfs/super.c +AHw- 2 +-- +AD4- 1 file changed, 1 insertion(+-), 1 deletion(-) +AD4- +AD4- diff --git a/fs/nfs/super.c b/fs/nfs/super.c +AD4- index 3f5a7a8..cebdb26 100644 +AD4- --- a/fs/nfs/super.c +AD4- +-+-+- b/fs/nfs/super.c +AD4- +AEAAQA- -2156,7 +-2156,7 +AEAAQA- nfs+AF8-compare+AF8-remount+AF8-data(struct nfs+AF8-server +ACo-nfss, +AD4- data-+AD4-nfs+AF8-server.addrlen +ACEAPQ- nfss-+AD4-nfs+AF8-client-+AD4-cl+AF8-addrlen +AHwAfA- +AD4- +ACE-rpc+AF8-cmp+AF8-addr((struct sockaddr +ACo-)+ACY-data-+AD4-nfs+AF8-server.address, +AD4- (struct sockaddr +ACo-)+ACY-nfss-+AD4-nfs+AF8-client-+AD4-cl+AF8-addr)) +AD4- - return -EINVAL+ADs- +AD4- +- return -EBUSY+ADs- +AD4- +AD4- return 0+ADs- +AD4- +AH0- The problem is that EBUSY also has a different meaning when it comes to remount. According to the manpage it means the source +ACI-cannot be remounted read-only, because it still holds files open for writing.+ACI- So, as far as I can see, this is a case of pick your poison... -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust+AEA-netapp.com www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
