On Oct 24, 2013, at 2:17 PM, Steve Dickson <SteveD@xxxxxxxxxx> wrote: > [ Here is the second try for these patches incorporating the code review..] > > Recently it was pointed out to me that the [-n | --no-tcp] flags > were broken in mountd. Sure enough they are and they broke > when nfs-utils moved to using libtirpc, which was years ago. > > Obviously nobody is using these flags since has not been > notice until now, Agreed, we have clear evidence of that. Removing the "no TCP" flag makes sense. > but it seemed to me it no longer makes > any sense to have flags. We really want people to use TCP > so why should there be a way to turn it off? It should be > the opposite... They should be able to turn off UDP listeners > not TCP... If noone is using --no-tcp now, what makes you believe that anyone would want to use --no-udp? And, why do we want to force people to use TCP for MNT? That's going to be a disaster for clients that perform a large number of mounts at once -- I think we even have bugs describing this scenario -- it will suck up the reserved port space on clients faster than you can say "Jack Robinson." Let's wait for a concrete user request for such a feature. > Steve Dickson (3): > mountd: Use protocol bit fields to turn protocols off. > mountd: Deprecate the ability to disable TCP listeners. > mountd: Add the ability to disable UDP listeners. > > support/include/rpcmisc.h | 2 +- > support/nfs/rpcmisc.c | 19 ++++++++++++++----- > support/nfs/svc_create.c | 5 +++++ > utils/mountd/mountd.c | 17 ++++++++++++----- > utils/mountd/mountd.man | 6 +++--- > 5 files changed, 35 insertions(+), 14 deletions(-) > > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Chuck Lever chuck[dot]lever[at]oracle[dot]com -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
