On 10/21/2013 05:25 PM, NeilBrown wrote: > On Wed, 2 Oct 2013 18:29:44 -0500 Tony Asleson <tasleson@xxxxxxxxxx> wrote: > >> To improve error handling when scripting exportfs it's useful >> to have non-zero exit codes when the requested operation did not >> succeed. >> >> This patch also returns a non-zero exit code if you request to >> unexport a non-existant share. >> >> Signed-off-by: Tony Asleson <tasleson@xxxxxxxxxx> > > This seems the have been forgotten, so maybe by replying to it someone will > notice (hi Steve). > > Though I agree with the need for the patch, I don't much like it's shape. > > Why change exportfs and unexportfs to return a status? The status is only > used to set export_errno, and they sometimes set export_errno anyway, so why > not leave them returning void and just setting export_errno as needed? The reason I chose to return values was to make sure requested operation actually completed requested operation. Unexporting a non-existent export is not considered an error and returns no indication you did absolutely nothing. When scripting exportfs from another program I wanted to know that the operation I requested actually did what I asked so that I could catch bad calls to it. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
