My original patch was to just fix the NULL dereference, but Trond noticed some other problems in _nfs4_opendata_reclaim_to_nfs4_state, so I went ahead and fixed them. I separated this into multiple patches for increased bisectability and made sure the NULL dereference patch was first so that stable@ / distros can choose to just fix the crash if they wish. I went a bit further than the issues Trond raised with the last patch, but I think it's good for consistency and catching reference counting bugs as errors and not BUG()s. -dros Weston Andros Adamson (5): NFSv4: fix NULL dereference in open recover NFSv4: don't fail on missing fattr in open recover NFSv4: clean up state ref counting in open recover NFSv4: don't reprocess cached open CLAIM_PREVIOUS NFSv4: clean up nfs4_state reference counting fs/nfs/nfs4proc.c | 39 +++++++++++++++++++++++++-------------- fs/nfs/nfs4state.c | 3 ++- 2 files changed, 27 insertions(+), 15 deletions(-) -- 1.7.12.4 (Apple Git-37) -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html