On Sun, Oct 06, 2013 at 10:44:32AM +0300, Benny Halevy wrote: > the nfs4_file can be found via the layout stateid. Oh, here we go. Really should be folded into the previous one to make sense. > /* Is this the first use of this layout ? */ > if (stid->sc_type != NFS4_LAYOUT_STID) { > + status = nfserr_bad_stateid; > + goto out; > } else { Given that you already have a goto out here there is no need for the else clause. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html