[PATCH] pynfs: fix reporting of ignored tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



currently, ignored tests reported as failure, which
makes fixing them quite hard.

Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@xxxxxxx>
---
 nfs4.1/testmod.py | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/nfs4.1/testmod.py b/nfs4.1/testmod.py
index 3d74efe..68855de 100644
--- a/nfs4.1/testmod.py
+++ b/nfs4.1/testmod.py
@@ -439,6 +439,7 @@ def printresults(tests, opts, file=None):
 def xml_printresults(tests, file_name, suite='all'):
     with open(file_name, 'w') as fd:
         failures = 0
+        skipped = 0
         total_time = 0
         doc = xml.dom.minidom.Document()
         testsuite = doc.createElement("testsuite")
@@ -455,14 +456,19 @@ def xml_printresults(tests, file_name, suite='all'):
             testcase.setAttribute("time", str(t.time_taken))
 
             total_time += t.time_taken
-            if t.result not in (TEST_PASS, TEST_WARN):
+            if t.result == TEST_FAIL:
                 failures += 1
                 failure = doc.createElement("failure")
                 failure.setAttribute("message", t.result.msg)
                 err = doc.createCDATASection(''.join(t.result.tb))
                 failure.appendChild(err)
                 testcase.appendChild(failure)
+            elif t.result == TEST_OMIT:
+                skipped += 1
+                skip = doc.createElement("skipped")
+                testcase.appendChild(skip)
 
         testsuite.setAttribute("failures", str(failures))
+        testsuite.setAttribute("skipped", str(skipped))
         testsuite.setAttribute("time", str(total_time))
         fd.write(doc.toprettyxml(indent="  "))
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux