On 2013-10-02 19:07, Christoph Hellwig wrote: > On Wed, Oct 02, 2013 at 02:36:54PM +0300, Benny Halevy wrote: >> I suggest moving the code in fs/nfsd/nfs4pnfsdlm.c to >> fs/dlm. > > I don't reall care where in the tree it lives, but it needs to be > neither part of nfsd or the filesystem (respectively dlm in this case). Just that this is dlm specific logic. For example, using dlm_ino_hash() in nfsd4_pnfs_dlm_layoutget(). Or even knowing that layout->lg_stripe_type = STRIPE_SPARSE; assumes knowledge of the underlying cluster fs implementation. Benny > > -- > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
