On 09/29/2013 05:20 AM, Benny Halevy wrote: > Makes sense. Thanks. > > Bruce - are you ok with moving the pnfs interface definitions to > include/linux/exportfs.h along with struct export_operations? > I disagree this is a bloat. It is big enough as it is. For code clarity and maintenance we should split. Yes they are related but then lots of stuff are related but we want to keep them separate compact and readable. why put everything in the same file, it does not make any sense. You have a library exportfs that exports a few related but different interfaces, In fact this header is not exported from exportfs it is the type system that defines the pnfs operations. They are so big and verbose they call for a separate header. > In fact we can actually extend struct export_operations rather > than adding pnfs_export_operations... > This is a great waist of space. Any FS that does not support pnfs, Which is currently all but exofs, will have 7 NULLs instead of one. And putting a struct pnfs_export_operations pointer inside struct export_operations gives you nothing but an extra dereference and funny looking code. Current system is just the most simple and most efficient. Why the extra complexity? > Benny Cheers Boaz -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
