Re: [PATCH] NFS: Give "flavor" an initial value to fix a compile warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sep 25, 2013, at 5:02 PM, bjschuma@xxxxxxxxxx wrote:

> From: Anna Schumaker <bjschuma@xxxxxxxxxx>
> 
> cd3c993 introduces a compile warning by not assigning an initial value
> to the "flavor" variable.  This could only be a problem if the server
> returns a supported secflavor list of length zero, but it's better to
> fix this before it's ever hit.
> 
> Signed-off-by: Anna Schumaker <bjschuma@xxxxxxxxxx>

Acked-by: Weston Andros Adamson <dros@xxxxxxxxxx>

Thanks!
-dros

> ---
> fs/nfs/nfs4proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index f5fe16b..d53d678 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -7576,7 +7576,7 @@ nfs41_find_root_sec(struct nfs_server *server, struct nfs_fh *fhandle,
> {
> 	int err;
> 	struct page *page;
> -	rpc_authflavor_t flavor;
> +	rpc_authflavor_t flavor = RPC_AUTH_MAXFLAVOR;
> 	struct nfs4_secinfo_flavors *flavors;
> 	struct nfs4_secinfo4 *secinfo;
> 	int i;
> -- 
> 1.8.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux