On 09/22, Toralf Förster wrote: > > On 07/27/2013 07:00 PM, Oleg Nesterov wrote: > > > > So nlmclnt_setlockargs()->utsname() crashes and we probably need > > the patch below. > > > > But is it correct? I know _absolutely_ nothing about nfs/sunrpc/etc and > > I never looked into this code before, most probably I am wrong. > > > > But it seems that __nlm_async_call() relies on workqueues. > > nlmclnt_async_call() does rpc_wait_for_completion_task(), but what if > > the caller is killed? > > > > nlm_rqst can't go away, ->a_count was incremented. But can't the caller > > exit before call->name is used? In this case the memory it points to > > can be already freed. > > > > Oleg. > > > > --- x/kernel/exit.c > > +++ x/kernel/exit.c > > @@ -783,8 +783,8 @@ void do_exit(long code) > > exit_shm(tsk); > > exit_files(tsk); > > exit_fs(tsk); > > - exit_task_namespaces(tsk); > > exit_task_work(tsk); > > + exit_task_namespaces(tsk); > > check_stack_usage(); > > exit_thread(); > > > > > > > /me wonders if/when this will go in the main kernel ? I think this was fixed by 9a1b6bf818e74 ? Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
