Re: [PATCH v2] NFS: Ensure that rmdir() waits for sillyrenames to complete

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sep03 18:50, Myklebust, Trond wrote:
> Thanks again for testing! Does the following fixup on top of the 'v2'
> patch also help?
> --- a/fs/nfs/unlink.c
> +++ b/fs/nfs/unlink.c
> @@ -211,7 +211,7 @@ void nfs_wait_on_sillyrename(struct dentry *dentry)
>  {
>  	struct nfs_inode *nfsi = NFS_I(dentry->d_inode);
>  
> -	wait_event(nfsi->waitqueue, atomic_read(&nfsi->silly_count) == 1);
> +	wait_event(nfsi->waitqueue, atomic_read(&nfsi->silly_count) <= 1);
>  }
>  
>  void nfs_block_sillyrename(struct dentry *dentry)

hmmm I just realized your v2 version had `== 1`; in fact I tested your v1
with `== 0`. Let me some time to retest the v2.

Thanks,

-- 
William

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux