Hi Trond,
This patch is causing this bug for me on my testing server:
[ 6.742695] BUG: unable to handle kernel NULL pointer dereference at (null)
[ 6.742791] IP: [<ffffffff812de260>] skip_spaces+0x30/0x30
[ 6.742848] PGD 1d719067 PUD 1de21067 PMD 0
[ 6.742900] Oops: 0000 [#1] PREEMPT SMP
[ 6.742949] Modules linked in: nfsd auth_rpcgss oid_registry nfs_acl snd_hda_intel pcspkr snd_hda_codec cirrus syscopyarea snd_hwdep sysfillrect psmouse snd_pcm serio_raw snd_page_alloc sysimgblt evdev snd_timer snd soundcore drm_kms_helper ttm drm i2c_piix4 i2c_core intel_agp intel_gtt button processor nfs lockd sunrpc fscache ata_generic pata_acpi btrfs libcrc32c xor zlib_deflate ata_piix crc32c_intel uhci_hcd libata scsi_mod usbcore usb_common raid6_pq floppy virtio_balloon virtio_net virtio_pci virtio_blk virtio_ring virtio
[ 6.743339] CPU: 0 PID: 211 Comm: rpc.nfsd Not tainted 3.11.0-rc2-ARCH+ #250
[ 6.743339] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
[ 6.743339] task: ffff88001bfc5c20 ti: ffff88001dff2000 task.ti: ffff88001dff2000
[ 6.743339] RIP: 0010:[<ffffffff812de260>] [<ffffffff812de260>] skip_spaces+0x30/0x30
[ 6.743339] RSP: 0018:ffff88001dff3bc8 EFLAGS: 00010282
[ 6.743339] RAX: ffffffffa025cb20 RBX: 0000000000000000 RCX: 0000000000000000
[ 6.743339] RDX: ffff88001de62838 RSI: 0000000000000000 RDI: 0000000000000000
[ 6.743339] RBP: ffff88001dff3bf0 R08: 0000000000017360 R09: 0000000000000000
[ 6.743339] R10: ffff88001e401700 R11: ffff88001dff3fd8 R12: ffff88001df2a000
[ 6.743339] R13: ffff88001cebca00 R14: 0000000000000000 R15: 0000000000000000
[ 6.743339] FS: 00007f04a4159700(0000) GS:ffff88001fc00000(0000) knlGS:0000000000000000
[ 6.743339] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 6.743339] CR2: 0000000000000000 CR3: 000000001df02000 CR4: 00000000000407f0
[ 6.743339] Stack:
[ 6.743339] ffffffffa0255dbe 0000000000000000 0000000000000000 ffff88001dff3d38
[ 6.743339] ffff88001cebca00 ffff88001dff3c38 ffffffffa023a0d9 ffffffff81511052
[ 6.743339] ffff88001de62800 00000000b2b4b509 ffff88001dff3d38 ffff88001cebca00
[ 6.743339] Call Trace:
[ 6.743339] [<ffffffffa0255dbe>] ? rpc_d_lookup_sb+0x2e/0x50 [sunrpc]
[ 6.743339] [<ffffffffa023a0d9>] rpc_setup_pipedir_sb+0x39/0xf0 [sunrpc]
[ 6.743339] [<ffffffff81511052>] ? mutex_lock+0x12/0x30
[ 6.743339] [<ffffffffa023c653>] rpc_new_client+0x233/0x450 [sunrpc]
[ 6.743339] [<ffffffffa023d3ec>] rpc_create+0xcc/0x250 [sunrpc]
[ 6.743339] [<ffffffffa024f1ec>] rpcb_create_local_unix+0x5c/0xe0 [sunrpc]
[ 6.743339] [<ffffffffa024ff98>] rpcb_create_local+0x68/0x80 [sunrpc]
[ 6.743339] [<ffffffffa0249a3e>] svc_rpcb_setup+0x1e/0x40 [sunrpc]
[ 6.743339] [<ffffffffa0249a89>] svc_bind+0x29/0x30 [sunrpc]
[ 6.743339] [<ffffffffa0498475>] nfsd_create_serv+0xd5/0x1a0 [nfsd]
[ 6.743339] [<ffffffffa049a000>] write_ports+0x2f0/0x350 [nfsd]
[ 6.743339] [<ffffffff811335ae>] ? __get_free_pages+0xe/0x50
[ 6.743339] [<ffffffff81133606>] ? get_zeroed_page+0x16/0x20
[ 6.743339] [<ffffffffa0499d10>] ? write_leasetime+0xa0/0xa0 [nfsd]
[ 6.743339] [<ffffffffa0499178>] nfsctl_transaction_write+0x48/0x80 [nfsd]
[ 6.743339] [<ffffffff811997cd>] vfs_write+0xbd/0x1e0
[ 6.743339] [<ffffffff8119a229>] SyS_write+0x49/0xa0
[ 6.743339] [<ffffffff8151b99d>] system_call_fastpath+0x1a/0x1f
[ 6.743339] Code: 89 f8 48 89 e5 f6 82 00 2a 64 81 20 74 15 0f 1f 44 00 00 48 83 c0 01 0f b6 10 f6 82 00 2a 64 81 20 75 f0 5d c3 66 0f 1f 44 00 00 <80> 3f 00 55 48 89 e5 74 15 48 89 f8 0f 1f 40 00 48 83 c0 01 80
[ 6.743339] RIP [<ffffffff812de260>] skip_spaces+0x30/0x30
[ 6.743339] RSP <ffff88001dff3bc8>
[ 6.743339] CR2: 0000000000000000
[ 6.750025] ---[ end trace 112065af093b07b3 ]---
On 08/28/2013 03:40 PM, Trond Myklebust wrote:
> The directory name is _always_ clnt->cl_program->pipe_dir_name.
>
> Signed-off-by: Trond Myklebust <Trond.Myklebust@xxxxxxxxxx>
> ---
> net/sunrpc/clnt.c | 17 ++++++-----------
> 1 file changed, 6 insertions(+), 11 deletions(-)
>
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index a327cc7..0cf4e09 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -123,10 +123,10 @@ static void rpc_clnt_remove_pipedir(struct rpc_clnt *clnt)
> }
>
> static struct dentry *rpc_setup_pipedir_sb(struct super_block *sb,
> - struct rpc_clnt *clnt,
> - const char *dir_name)
> + struct rpc_clnt *clnt)
> {
> static uint32_t clntid;
> + const char *dir_name = clnt->cl_program->pipe_dir_name;
> char name[15];
> struct dentry *dir, *dentry;
>
> @@ -153,15 +153,12 @@ static struct dentry *rpc_setup_pipedir_sb(struct super_block *sb,
> }
>
> static int
> -rpc_setup_pipedir(struct rpc_clnt *clnt, const char *dir_name,
> - struct super_block *pipefs_sb)
> +rpc_setup_pipedir(struct super_block *pipefs_sb, struct rpc_clnt *clnt)
> {
> struct dentry *dentry;
>
> clnt->cl_dentry = NULL;
> - if (dir_name == NULL)
> - return 0;
> - dentry = rpc_setup_pipedir_sb(pipefs_sb, clnt, dir_name);
> + dentry = rpc_setup_pipedir_sb(pipefs_sb, clnt);
> if (IS_ERR(dentry))
> return PTR_ERR(dentry);
> clnt->cl_dentry = dentry;
> @@ -186,8 +183,7 @@ static int __rpc_clnt_handle_event(struct rpc_clnt *clnt, unsigned long event,
>
> switch (event) {
> case RPC_PIPEFS_MOUNT:
> - dentry = rpc_setup_pipedir_sb(sb, clnt,
> - clnt->cl_program->pipe_dir_name);
> + dentry = rpc_setup_pipedir_sb(sb, clnt);
> if (!dentry)
> return -ENOENT;
> if (IS_ERR(dentry))
> @@ -282,7 +278,6 @@ static void rpc_clnt_set_nodename(struct rpc_clnt *clnt, const char *nodename)
> static int rpc_client_register(const struct rpc_create_args *args,
> struct rpc_clnt *clnt)
> {
> - const struct rpc_program *program = args->program;
> struct rpc_auth *auth;
> struct net *net = rpc_net_ns(clnt);
> struct super_block *pipefs_sb;
> @@ -290,7 +285,7 @@ static int rpc_client_register(const struct rpc_create_args *args,
>
> pipefs_sb = rpc_get_sb_net(net);
> if (pipefs_sb) {
> - err = rpc_setup_pipedir(clnt, program->pipe_dir_name, pipefs_sb);
> + err = rpc_setup_pipedir(pipefs_sb, clnt);
> if (err)
> goto out;
> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
