On Wed, 2013-07-31 at 18:00 -0500, Quentin Barnes wrote: > > Quite frankly, all I care about in a situation like this is that the > > client doesn't Oops. > > Certainly, and his patch does do that, but it's also pointing out > there's another bug running around. And once you fix that bug, the > original patch is no longer needed. > > > If a server is really this utterly broken, then there is no way we can > > fix it on the client, and we're not even going to try. > > Of course. But you also don't want to unnecessarily leave the > client with an invalid inode that's not properly flagged and > possibly leave another bug unfixed. Why is the invalid inode not being flagged a problem that needs to be solved? How does the patch that you've proposed change matters for the end user or application? -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com ��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥