On 07/28, Eric W. Biederman wrote: > > > This untested patch should fix it without any need to worry about > > dynamic behavior. Yeees ;) I was thinking about this change too, but I have no idea what this ->nodename actually means for nfs. If you are going to send this patch - great! > Although I am wondering if we have a few other spots > > where the dynamic behavior might be iffy. Yes. And perhaps the patch which moves exit_task_namespaces() after exit_task_work() makes sense anyway (the patch I showed). (but if you change nlmclnt_setlockargs() then it is not 3.11 material). The original motivation for 8aac62706 was the leak reported by Andrey, but that leak should be also fixed by e7b2c406. "Move exit_task_namespaces() from exit_notify() to do_exit()" is still fine imho, the reason for exit_task_namespaces() from the middle of exit_notify() has gone away. But perhaps it would be better if work->func() could use ->nsproxy even if the task is PF_EXITING. > > Serge do you remember any of this? > > > > On a good day I can follow the nfs code but it takes quite a while. I > > feel the same way about filesystems locks so I am not really certain > > what is going on. > > > > Eric > > > > diff --git a/fs/lockd/clntproc.c b/fs/lockd/clntproc.c > > index 9760ecb..6643cfc 100644 > > --- a/fs/lockd/clntproc.c > > +++ b/fs/lockd/clntproc.c > > @@ -128,11 +128,11 @@ static void nlmclnt_setlockargs(struct nlm_rqst *req, struct file_lock *fl) > > > > nlmclnt_next_cookie(&argp->cookie); > > memcpy(&lock->fh, NFS_FH(file_inode(fl->fl_file)), sizeof(struct nfs_fh)); > > - lock->caller = utsname()->nodename; > > + lock->caller = init_utsname()->nodename; > > lock->oh.data = req->a_owner; > > lock->oh.len = snprintf(req->a_owner, sizeof(req->a_owner), "%u@%s", > > (unsigned int)fl->fl_u.nfs_fl.owner->pid, > > - utsname()->nodename); > > + init_utsname()->nodename); > > lock->svid = fl->fl_u.nfs_fl.owner->pid; > > lock->fl.fl_start = fl->fl_start; > > lock->fl.fl_end = fl->fl_end; > > > > Eric -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
