Re: [PATCH 2/2] NFSv4: encode_attrs should not backfill the bitmap and attribute length

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 23, 2013 at 7:00 PM, Myklebust, Trond
<Trond.Myklebust@xxxxxxxxxx> wrote:
> On Tue, 2013-07-23 at 17:59 +0200, Andre Heider wrote:
>> Trond,
>>
>> On Wed, Jul 17, 2013 at 11:59 PM, Trond Myklebust
>> <Trond.Myklebust@xxxxxxxxxx> wrote:
>> > The attribute length is already calculated in advance. There is no
>> > reason why we cannot calculate the bitmap in advance too so that
>> > we don't have to play pointer games.
>>
>> I'm sorry to report that this patch seems to be more than just a cleanup.
>>
>> I just tested 3.11-rc2 against my FreeBSD server, and with just patch
>> 1/2 (as in -rc2) I still get the failure upon `touch`. It fails with
>> or without Rick's server patch.
>>
>> Applying this one on top of -rc2 fixes it.
>
> How about the attached instead of the cleanup?

Much better ;) Thanks again for the quick fix!

Feel free to add:
Tested-by: Andre Heider <a.heider@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux