Re: [PATCH 1/4] NFSv4.1 Use the mount point rpc_clnt for layoutreturn

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2013-07-22 at 12:44 -0400, Trond Myklebust wrote:
> On Mon, 2013-07-22 at 12:42 -0400, andros@xxxxxxxxxx wrote:
> > From: Andy Adamson <andros@xxxxxxxxxx>
> > 
> > Should not use the clientid maintenance rpc_clnt.
> > 
> > Signed-off-by: Andy Adamson <andros@xxxxxxxxxx>
> > ---
> >  fs/nfs/nfs4proc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> > index cf11799..7a846b6 100644
> > --- a/fs/nfs/nfs4proc.c
> > +++ b/fs/nfs/nfs4proc.c
> > @@ -6876,7 +6876,7 @@ int nfs4_proc_layoutreturn(struct nfs4_layoutreturn *lrp)
> >  		.rpc_cred = lrp->cred,
> >  	};
> >  	struct rpc_task_setup task_setup_data = {
> > -		.rpc_client = lrp->clp->cl_rpcclient,
> > +		.rpc_client = NFS_SERVER(lrp->args.inode)->client,
> >  		.rpc_message = &msg,
> >  		.callback_ops = &nfs4_layoutreturn_call_ops,
> >  		.callback_data = lrp,
> 
> NACK. LAYOUTRETURN needs to use the same credential as LAYOUTGET.
> 

Never mind. I completely misread the patch.

Agreed that this is the right thing to do.
-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@xxxxxxxxxx
www.netapp.com
��.n��������+%������w��{.n�����{��w���jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Linux Filesystem Development]     [Linux USB Development]     [Linux Media Development]     [Video for Linux]     [Linux NILFS]     [Linux Audio Users]     [Yosemite Info]     [Linux SCSI]

  Powered by Linux