> -----Original Message----- > From: linux-nfs-owner@xxxxxxxxxxxxxxx [mailto:linux-nfs- > owner@xxxxxxxxxxxxxxx] On Behalf Of Chuck Lever > Sent: Friday, July 19, 2013 7:57 PM > To: Adamson, Andy > Cc: Linux NFS Mailing List > Subject: Re: [PATCH 1/1] NFSv4.1 Increase NFS4_DEF_SLOT_TABLE_SIZE > > Hi Andy- > > On Jul 19, 2013, at 5:09 PM, andros@xxxxxxxxxx wrote: > > > From: Andy Adamson <andros@xxxxxxxxxx> > > > > max_session_slots is a ushort. Bump NFS4_DEF_SLOT_TABLE_SIZE to the > > max ushort > > value: e.g. ask for 256 slots and let the server negotiate down if needed. > > I don't have an objection to your patch, but the description is confusing. > > In fs/nfs/super.c I see > > unsigned short max_session_slots = NFS4_DEF_SLOT_TABLE_SIZE; > > but /usr/include/limits.h has > > #define USHRT_MAX 65535 > > The maximum value you can store in an unsigned octet is 255 (UCHAR_MAX). > > Why did you choose 256 and not 65535? This is the _minimum_ number of slots that the client and server will have to allocate, even when they both support dynamic slots, so we don't want to set it unreasonably high. I realise that most servers will negotiate this value down, but we don't want to rely on that. Cheers Trond -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
