On Tue, Jul 02, 2013 at 01:00:52PM -0400, Jeff Layton wrote: > Currently the way these get set is a little convoluted. If the dentry is > allocated via lookup from userland, then it gets set by simple_lookup. > If it gets allocated when the kernel is populating the directory, then > it gets set via __rpc_lookup_create_exclusive, which has to check > whether they might already be set. Between both of these, this ensures > that all dentries have their d_op pointer set. > > Instead of doing that, just have them set at d_alloc time by pointing > sb->s_d_op at them. With that change, we no longer want the lookup op > to set them, so we must move to using our own lookup routine. There's a better solution - just make simple_lookup() skip d_set_d_op() if superblock already has ->s_d_op (and thus d_alloc() has already set the damn thing). Voila - we can just set ->s_d_op and leave inode_operations as is. -- To unsubscribe from this list: send the line "unsubscribe linux-nfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
