Update the patch as suggested. Here is the patch... -- Cheers, Nasf -----Original Message----- From: Myklebust, Trond [mailto:Trond.Myklebust@xxxxxxxxxx] Sent: Thursday, May 23, 2013 8:50 PM To: Peng Tao Cc: Dilger, Andreas; J. Bruce Fields; linux-nfs@xxxxxxxxxxxxxxx; Yong, Fan; Steve Dickson Subject: Re: [PATCH] nfs: support 64-bit root inode number in NFS FSID On Thu, 2013-05-23 at 16:12 +0800, Peng Tao wrote: > [nfs-utils patch needs to be sent to Steve Dickson (CC'ed)] > > On Thu, May 23, 2013 at 7:06 AM, Dilger, Andreas > <andreas.dilger@xxxxxxxxx> wrote: > > When exporting a filesystem via NFS, it can generate several kinds > > of NFS filesystem IDs. For most of cases, it uses a 32-bit inode > > number in the NFS FSID, but this does not work on a filesystem using > > a 64-bit root inode number. > > > > In kernel space, NFS can generate/use NFS FSID with a 64-bit inode > > number for the "FSID_UUID16_INUM" type. Unfortunately, while the > > user space nfs-utils decode the 64-bit inode number from the FSID > > correctly, it is truncated when storing it in "struct parsed_fsid". > > Expand the "struct parsed_fsid" inode field to store the full 64-bit > > root inode number. > > > > Intel-bug-id: LU-2904 > > Signed-off-by: Fan Yong <fan.yong@xxxxxxxxx> > > Signed-off-by: Andreas Dilger <andreas.dilger@xxxxxxxxx> > > --- > > utils/mountd/cache.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/utils/mountd/cache.c b/utils/mountd/cache.c index > > 517aa62..a7212e7 100644 > > --- a/utils/mountd/cache.c > > +++ b/utils/mountd/cache.c > > @@ -388,7 +388,7 @@ struct parsed_fsid { > > int fsidtype; > > /* We could use a union for this, but it would be more > > * complicated; why bother? */ > > - unsigned int inode; > > + unsigned long long inode; /* We need 64-bits ino# */ > > unsigned int minor; > > unsigned int major; > > unsigned int fsidnum; > > --1.7.1 > > > > Patch is also attached separately, since it will likely be butchered > > by this email client. > > > > > > Cheers, Andreas > > -- > > Andreas Dilger Why not just specify a uint64_t size then? -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com
Attachment:
0001-nfs-support-64-bit-root-inode-number-in-NFS-FSID.patch
Description: 0001-nfs-support-64-bit-root-inode-number-in-NFS-FSID.patch
